[dm-crypt] goto patch for cryptsetup?
arno at wagner.name
Fri Mar 7 00:27:21 CET 2014
I don't think that is a good idea. The "goto fail" was a
problem due to either a high level of incompetence, or
due to intent disguised as a high level of incompetence.
I think well-placed gotos are actually clearer and less
risky than the structured programming equivalents.
What happened with iOS would have been blatantly
obvious with even minimal code review or a single
test-case for the skipped functionality. That these
were not done is pretty bad.
Of course, the final decision is Milan's. But I think
what would be far better is that you review all these
goto's as to whether any of them is a problem. That is
still less useful than a real review, but at least it
may alleviate the concerns of the "syntactic matching
people" that see the "goto" as a problem (or "sha-1",
or the like) instead of the specific use.
On Thu, Mar 06, 2014 at 21:39:11 CET, Lars Winterfeld wrote:
> in light of the latest "goto fail"s out there, would you reject a patch
> replacing all 328 gotos with their semantic equivalents from structured
> C programming?
> Best wishes,
> dm-crypt mailing list
> dm-crypt at saout.de
Arno Wagner, Dr. sc. techn., Dipl. Inform., Email: arno at wagner.name
GnuPG: ID: CB5D9718 FP: 12D6 C03B 1B30 33BB 13CF B774 E35C 5FA1 CB5D 9718
A good decision is based on knowledge and not on numbers. - Plato
More information about the dm-crypt