[dm-crypt] goto patch for cryptsetup?

Milan Broz gmazyland at gmail.com
Fri Mar 7 06:23:41 CET 2014


On 03/06/2014 09:39 PM, Lars Winterfeld wrote:
> Hi,
> 
> in light of the latest "goto fail"s out there, would you reject a patch
> replacing all 328 gotos with their semantic equivalents from structured
> C programming?

cryptsetup code uss goto for only one purpose: to have only one exit
place from a function (with check for errors, release memory).

Replacing it with anything else means duplicating of lot of code.

Read e.g. kernel code, you will se the same patern on many places.

Milan


More information about the dm-crypt mailing list