[dm-crypt] [PATCH] include sys/sysmacros.h for major/minor/makedev

Mike Frysinger vapier at gentoo.org
Tue Apr 19 17:22:12 CEST 2016


On 19 Apr 2016 11:06, Milan Broz wrote:
> On 04/19/2016 08:53 AM, Mike Frysinger wrote:
> > On 19 Apr 2016 08:34, Milan Broz wrote:
> >> On 04/19/2016 08:16 AM, Mike Frysinger wrote:
> ...
> >>> +#include <sys/sysmacros.h>
> >>
> >> Shouldn't we also check for existence of this header in autoconf?
> >> I do not think it is present on all systems (FreeBSD?).
> > 
> > i couldn't tell how portable this code base was trying to be or if it
> > was assuming Linux.  if you want to be portable w/autoconf, should be
> > easy to do:
> > (1) call AC_HEADER_MAJOR in configure.ac
> > (2) use the idiom:
> > #ifdef MAJOR_IN_MKDEV
> > # include <sys/mkdev.h>
> > #elif defined(MAJOR_IN_SYSMACROS)
> > # include <sys/sysmacros.h>
> > #endif
> 
> I fixed it with this commit
> https://gitlab.com/cryptsetup/cryptsetup/commit/54c4b1656f93997ae5624051c91ea10249e5a823

that'll work for us too.  thanks!
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://www.saout.de/pipermail/dm-crypt/attachments/20160419/748da97e/attachment.asc>


More information about the dm-crypt mailing list