[dm-crypt] [PATCH] Speed up keyfile reading

Milan Broz gmazyland at gmail.com
Sat Aug 12 21:37:17 CEST 2017


Hi,

On 08/12/2017 08:26 PM, angelomariafederichini191269 wrote:
> (Sorry if this mailing list isn't the right place for patches but I
> couldn't find any instructions on how to contribute. Maybe that's worth
> a FAQ entry by its own.)

Just FYI:
The best way is either this mailing list or create new issue or merge request
on the gitlab project pages (https://gitlab.com/cryptsetup/cryptsetup).
Github has mirror of repo so you can also create merge request there
as well (https://github.com/mbroz/cryptsetup)

> I'm using a keyfile instead of a passphrase for my encrypted volumes.
> What me bothered a long time is that it takes nearly 30 seconds to open
> the volume. Now I had a little time and dug into this itch.

How big is that keyfile? (And what is underlying storage?)
Just wonder why it is so slow...

Anyway, patches look good, I will commit it later.

...
> Below is the "test case code" (I wouldn't call it code). It is not a patch
> because I did not understand the test suite. So someone with more knowledge
> might want to convert these into more suitable test cases. The tests also need
> manual supervision (looking at the output to decide if the test succeeded).

The testsuite is just bunch of bash script that runs after "make check"
(and also they run in Travis on Github automatically).
It should be quite easy to add your tests but I think I have most of the
magic with handling EOL etc already there (at least for keyfile on stdin).

Thanks,
Milan



More information about the dm-crypt mailing list